Route isAttackedIn through the PieceReader port #119

New issue

Closed

opened 2026-05-22 12:39:58 +00:00 by root · 8 comments

root commented

2026-05-22 12:39:58 +00:00

(Migrated from gitlab.core-project.space)

Imported from GitHub amaurycoudr/chess-project#119, opened by @amaurycoudr on 2026-05-22 12:39 UTC.
Closed on GitHub on 2026-05-23 06:28 UTC as completed.

Parent

#117

What to build

Route isAttackedIn through the PieceReader port. Today it takes the raw { sets: PieceSets; occupancy: SquareSet } pair, and its two callers assemble that argument differently — rules.isCheck passes a fresh position.board.toSets() copy, SearchBoard.legalMoves passes the live #sets ref plus a separately-computed occupancy. This slice replaces that parameter with a single PieceReader, derived occupancy included, so both callers pass a board directly.

End-to-end: attack detection runs identically whether handed an immutable snapshot or a live board, with one calling convention.

Acceptance criteria

isAttackedIn signature changed from { sets, occupancy } to a PieceReader; occupancy derived internally via pieceReader.occupancy()
rules.isCheck passes position.board directly — no toSets() copy, no hand-rolled occupancy
SearchBoard.legalMoves passes its board through the port — no { sets, occupancy } tuple
attacks.test.ts updated to drive isAttackedIn via a PieceReader
pnpm lint, pnpm typecheck, pnpm test, pnpm build all green; perft node counts unchanged

Blocked by

Blocked by #118

> _Imported from GitHub [amaurycoudr/chess-project#119](https://github.com/amaurycoudr/chess-project/issues/119), opened by [@amaurycoudr](https://github.com/amaurycoudr) on 2026-05-22 12:39 UTC._ > _Closed on GitHub on 2026-05-23 06:28 UTC as completed._  --- ## Parent #117 ## What to build Route `isAttackedIn` through the `PieceReader` port. Today it takes the raw `{ sets: PieceSets; occupancy: SquareSet }` pair, and its two callers assemble that argument differently — `rules.isCheck` passes a fresh `position.board.toSets()` copy, `SearchBoard.legalMoves` passes the live `#sets` ref plus a separately-computed occupancy. This slice replaces that parameter with a single `PieceReader`, derived occupancy included, so both callers pass a board directly. End-to-end: attack detection runs identically whether handed an immutable snapshot or a live board, with one calling convention. ## Acceptance criteria - [ ] `isAttackedIn` signature changed from `{ sets, occupancy }` to a `PieceReader`; occupancy derived internally via `pieceReader.occupancy()` - [ ] `rules.isCheck` passes `position.board` directly — no `toSets()` copy, no hand-rolled occupancy - [ ] `SearchBoard.legalMoves` passes its board through the port — no `{ sets, occupancy }` tuple - [ ] `attacks.test.ts` updated to drive `isAttackedIn` via a `PieceReader` - [ ] `pnpm lint`, `pnpm typecheck`, `pnpm test`, `pnpm build` all green; perft node counts unchanged ## Blocked by - Blocked by #118

root commented

2026-05-22 12:50:50 +00:00

(Migrated from gitlab.core-project.space)

Imported from a GitHub comment by @amaurycoudr on 2026-05-22 12:50 UTC.

Implemented by Sandcastle on branch sandcastle/sequential-reviewer/1779453986599 — awaiting review. Routed isAttackedIn through the PieceReader port: signature collapsed from { sets, occupancy } to a single PieceReader, with rules.isCheck and both SearchBoard.legalMoves callsites passing the board directly; attacks.test.ts drives the function via pos.board (no more attackContext helper). All four gates green; perft node counts unchanged.

> _Imported from a [GitHub comment](https://github.com/amaurycoudr/chess-project/issues/119#issuecomment-4518792082) by [@amaurycoudr](https://github.com/amaurycoudr) on 2026-05-22 12:50 UTC._  Implemented by Sandcastle on branch `sandcastle/sequential-reviewer/1779453986599` — awaiting review. Routed `isAttackedIn` through the `PieceReader` port: signature collapsed from `{ sets, occupancy }` to a single `PieceReader`, with `rules.isCheck` and both `SearchBoard.legalMoves` callsites passing the board directly; `attacks.test.ts` drives the function via `pos.board` (no more `attackContext` helper). All four gates green; perft node counts unchanged.

root commented

2026-05-22 14:20:02 +00:00

(Migrated from gitlab.core-project.space)

Imported from a GitHub comment by @amaurycoudr on 2026-05-22 14:20 UTC.

Promoted to branch refactor/introduce-the-piecereader-read-port-118 (PR #122), not yet merged to main. A dependent slice should git fetch origin refactor/introduce-the-piecereader-read-port-118 and branch off it.

> _Imported from a [GitHub comment](https://github.com/amaurycoudr/chess-project/issues/119#issuecomment-4519525548) by [@amaurycoudr](https://github.com/amaurycoudr) on 2026-05-22 14:20 UTC._  Promoted to branch `refactor/introduce-the-piecereader-read-port-118` (PR #122), not yet merged to main. A dependent slice should `git fetch origin refactor/introduce-the-piecereader-read-port-118` and branch off it.

root (Migrated from gitlab.core-project.space) closed this issue

2026-05-23 06:28:33 +00:00

root commented

2026-10-13 08:38:43 +00:00

(Migrated from gitlab.core-project.space)

mentioned in issue #120