Amend ADR 0016: a vacated Seat replaces the 60-second left timer #244

New issue

Closed

opened 2026-10-05 08:19:12 +00:00 by root · 6 comments

root commented

2026-10-05 08:19:12 +00:00

(Migrated from gitlab.core-project.space)

Imported from GitHub amaurycoudr/chess-project#244, opened by @amaurycoudr on 2026-10-05 08:19 UTC.
Closed on GitHub on 2026-10-05 12:11 UTC as completed.

Parent

#243

What to build

Amend ADR 0016 so it matches the presence model #243 decided. The bullet "Opponent left is a 60-second client timer; the server keeps the Seat for the full TTL" is replaced:

a disconnected Seat is still its Player's for the whole TTL, and the front says so ("Your opponent lost connection.") with no client timer;
a Seat freed through room.leave is vacated, a third state distinct from a never-taken Seat, and the snapshot carries it. A later join makes it taken again.

Record the rejected alternative: the 60-second timer, which told the Player a lie while the Seat was still held.

This is a rule edit, done in its own PR as CLAUDE.md requires; the owner asked for it in the conversation that produced #243.

Seam: none (documentation only).

Acceptance criteria

ADR 0016 describes the three Seat states and drops the 60-second timer.
The rejected timer is listed under Rejected, with why.
The ADR index still points at it correctly.

> _Imported from GitHub [amaurycoudr/chess-project#244](https://github.com/amaurycoudr/chess-project/issues/244), opened by [@amaurycoudr](https://github.com/amaurycoudr) on 2026-10-05 08:19 UTC._ > _Closed on GitHub on 2026-10-05 12:11 UTC as completed._  --- ## Parent #243 ## What to build Amend ADR 0016 so it matches the presence model #243 decided. The bullet "Opponent left is a 60-second client timer; the server keeps the Seat for the full TTL" is replaced: - a disconnected Seat is still its Player's for the whole TTL, and the front says so ("Your opponent lost connection.") with no client timer; - a Seat freed through `room.leave` is **vacated**, a third state distinct from a never-taken Seat, and the snapshot carries it. A later `join` makes it taken again. Record the rejected alternative: the 60-second timer, which told the Player a lie while the Seat was still held. This is a rule edit, done in its own PR as CLAUDE.md requires; the owner asked for it in the conversation that produced #243. Seam: none (documentation only). ## Acceptance criteria - [ ] ADR 0016 describes the three Seat states and drops the 60-second timer. - [ ] The rejected timer is listed under Rejected, with why. - [ ] The ADR index still points at it correctly.

root commented

2026-10-05 08:19:12 +00:00

(Migrated from gitlab.core-project.space)

GitHub issue relations, imported as "related" links (GitLab CE has no sub-issues or blocking links).

Parent (sub-issue of): #243
Blocking: #248

> _GitHub issue relations, imported as "related" links (GitLab CE has no sub-issues or blocking links)._  - Parent (sub-issue of): #243 - Blocking: #248

root (Migrated from gitlab.core-project.space) closed this issue

2026-10-05 12:11:21 +00:00

root commented

2026-10-13 08:39:15 +00:00

(Migrated from gitlab.core-project.space)

mentioned in issue #248