Fold the Room into RoomService, so the Room's report type needs no framework-free file #393

New issue

Closed

opened 2026-10-13 15:31:18 +00:00 by root · 9 comments

root commented

2026-10-13 15:31:18 +00:00

(Migrated from gitlab.core-project.space)

Parent

#355

What to build

Fold the API's Room (apps/api/src/room/room.ts) into RoomService, so room/ holds its module, controller and service and no separate framework-free Room class.

Why: Guest history put the DecidedGame type, the record a Room reports once its Game is decided, in games/games.service.ts. room.ts imports it, and under verbatimModuleSyntax that type-only import still loads the service (Nest, drizzle) at runtime, breaking API rule 1 ("room.ts stays framework-free"). The owner chose to remove the split rather than move the type.

The per-Room state and its rules (seating by Guest, Moves, Offers, nudges, restarts, the decided-Game report) live in the service, keyed by Room code; behaviour is unchanged.
The Room's tests (room.test.ts, room-play, room-offer, room-offer-unanswered, room-nudge, room-decided, room-changes) are kept, going through RoomService's public methods with room.fixtures.ts; no coverage is lost.
apps/api/CODING_STANDARDS.md (layout paragraph, rules 1, 3 and 6) is rewritten to match, at the owner's request in this merge request. The lint config's room.ts framework-free entry is updated accordingly.

Seam: RoomService's public methods with room.fixtures.ts, unit; the RPC wire stays green unchanged.

Acceptance criteria

apps/api/src/room/room.ts no longer exists; its behaviour lives in RoomService.
Every existing Room test still passes, rewritten to go through RoomService where it built a Room directly; no test is dropped without an equivalent.
The RPC integration tests and e2e pass unchanged.
apps/api/CODING_STANDARDS.md and the lint config describe the new layout; no stale mention of a framework-free room.ts remains.

## Parent #355 ## What to build Fold the API's `Room` (`apps/api/src/room/room.ts`) into `RoomService`, so `room/` holds its module, controller and service and no separate framework-free `Room` class. Why: Guest history put the `DecidedGame` type, the record a **Room** reports once its **Game** is decided, in `games/games.service.ts`. `room.ts` imports it, and under `verbatimModuleSyntax` that type-only import still loads the service (Nest, drizzle) at runtime, breaking API rule 1 ("`room.ts` stays framework-free"). The owner chose to remove the split rather than move the type. - The per-**Room** state and its rules (seating by **Guest**, **Moves**, **Offers**, nudges, restarts, the decided-**Game** report) live in the service, keyed by **Room code**; behaviour is unchanged. - The **Room**'s tests (`room.test.ts`, `room-play`, `room-offer`, `room-offer-unanswered`, `room-nudge`, `room-decided`, `room-changes`) are kept, going through `RoomService`'s public methods with `room.fixtures.ts`; no coverage is lost. - `apps/api/CODING_STANDARDS.md` (layout paragraph, rules 1, 3 and 6) is rewritten to match, at the owner's request in this merge request. The lint config's `room.ts` framework-free entry is updated accordingly. Seam: `RoomService`'s public methods with `room.fixtures.ts`, unit; the RPC wire stays green unchanged. ## Acceptance criteria - [ ] `apps/api/src/room/room.ts` no longer exists; its behaviour lives in `RoomService`. - [ ] Every existing Room test still passes, rewritten to go through `RoomService` where it built a `Room` directly; no test is dropped without an equivalent. - [ ] The RPC integration tests and e2e pass unchanged. - [ ] `apps/api/CODING_STANDARDS.md` and the lint config describe the new layout; no stale mention of a framework-free `room.ts` remains.

root commented

2026-10-13 15:31:31 +00:00

(Migrated from gitlab.core-project.space)

marked this issue as related to #355