Move the Account delete dialog onto TanStack Form v2 #420

Closed
opened 2026-10-15 12:34:37 +00:00 by root · 7 comments
root commented 2026-10-15 12:34:37 +00:00 (Migrated from gitlab.core-project.space)

Parent

#410

What to build

The Account delete dialog's password form runs on the shared TanStack Form v2 module. A signed-in Player sees the same dialog: delete disabled until a password is typed, a wrong password refused inside the dialog, and a clean form when the dialog opens again.

Seam: S1 — the account page with the auth harness and MSW.

Acceptance criteria

  • The dialog's form uses the shared module; no per-field useState remains in it.
  • A wrong password is returned from onSubmit as a field error, never thrown.
  • Reopening the dialog resets the form and its refusal.
  • The existing account-page deletion tests pass unchanged in what they assert.
## Parent #410 ## What to build The Account delete dialog's password form runs on the shared TanStack Form v2 module. A signed-in Player sees the same dialog: delete disabled until a password is typed, a wrong password refused inside the dialog, and a clean form when the dialog opens again. Seam: S1 — the account page with the auth harness and MSW. ## Acceptance criteria - [ ] The dialog's form uses the shared module; no per-field `useState` remains in it. - [ ] A wrong password is returned from `onSubmit` as a field error, never thrown. - [ ] Reopening the dialog resets the form and its refusal. - [ ] The existing account-page deletion tests pass unchanged in what they assert.
root commented 2026-10-15 12:34:37 +00:00 (Migrated from gitlab.core-project.space)

marked this issue as related to #410

marked this issue as related to #410
root commented 2026-10-15 12:34:37 +00:00 (Migrated from gitlab.core-project.space)

marked this issue as related to #418

marked this issue as related to #418
root commented 2026-10-15 22:17:25 +00:00 (Migrated from gitlab.core-project.space)

mentioned in commit 5c7ad5b3944c8a7a24b0d4550b8a0c961647a0c5

mentioned in commit 5c7ad5b3944c8a7a24b0d4550b8a0c961647a0c5
root commented 2026-10-15 22:17:35 +00:00 (Migrated from gitlab.core-project.space)

mentioned in merge request !543

mentioned in merge request !543
root commented 2026-10-15 22:18:21 +00:00 (Migrated from gitlab.core-project.space)

mentioned in commit 356cb02ed3

mentioned in commit 356cb02ed330497c93bf587fe752042e8ba15526
root commented 2026-10-15 22:52:48 +00:00 (Migrated from gitlab.core-project.space)

mentioned in commit ed624c3d52ff77ce592b6ffb6e66f431b821900c

mentioned in commit ed624c3d52ff77ce592b6ffb6e66f431b821900c
root commented 2026-10-15 22:54:57 +00:00 (Migrated from gitlab.core-project.space)

mentioned in commit 8a1be3fd64

mentioned in commit 8a1be3fd64d045587b4036ab993f43c49b389c98
root (Migrated from gitlab.core-project.space) closed this issue 2026-10-15 23:25:53 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference
amaurycoudr/chess-project#420
No description provided.