Rate limiter in auth, its defaults in config, the doorbell in room #423

New issue

Closed

opened 2026-10-15 14:45:15 +00:00 by root · 5 comments

root commented

2026-10-15 14:45:15 +00:00

(Migrated from gitlab.core-project.space)

Parent

#421

What to build

common/ loses the two files that each have one client, and the config folder stops loading Nest.

The rate-limit types and defaults move into the config module's file.
The rate-limit service moves to auth, its only client.
The doorbell moves to room, beside the change stream that alone uses it.

Sign-up, sign-in and reset requests are limited exactly as before (ADR 0041).

Seam: S3, the API lint through its test; S1, the rate-limit integration tests, unchanged in what they assert.

Acceptance criteria

The config folder imports nothing from a Nest file, directly or through the rate limiter. The migration script no longer loads Nest.
The rate-limit service lives in auth and reads its types and defaults from config.
The doorbell lives in room. common/ no longer holds it.
The framework-imports lint test covers the moved files: framework-free where required, Nest allowed for the service.
The rate-limit integration tests pass unchanged in what they assert.

## Parent #421 ## What to build `common/` loses the two files that each have one client, and the config folder stops loading Nest. - The rate-limit types and defaults move into the config module's file. - The rate-limit service moves to auth, its only client. - The doorbell moves to room, beside the change stream that alone uses it. Sign-up, sign-in and reset requests are limited exactly as before (ADR 0041). Seam: S3, the API lint through its test; S1, the rate-limit integration tests, unchanged in what they assert. ## Acceptance criteria - [ ] The config folder imports nothing from a Nest file, directly or through the rate limiter. The migration script no longer loads Nest. - [ ] The rate-limit service lives in auth and reads its types and defaults from config. - [ ] The doorbell lives in room. `common/` no longer holds it. - [ ] The framework-imports lint test covers the moved files: framework-free where required, Nest allowed for the service. - [ ] The rate-limit integration tests pass unchanged in what they assert.

root commented

2026-10-15 14:45:57 +00:00

(Migrated from gitlab.core-project.space)

marked this issue as related to #421