Update ADR 0041: sign-in failures are counted per email and IP #439

New issue

Closed

opened 2026-10-16 06:01:40 +00:00 by root · 5 comments

root commented

2026-10-16 06:01:40 +00:00

(Migrated from gitlab.core-project.space)

ADR 0041 (docs/adr/0041-rate-limits-are-in-memory-counters-in-the-api.md) no longer matches the code:

Line 8 says counters are keyed "by IP and by lowercased email"; the sign-in failure counter is now keyed by email and IP together.
Line 12 speaks of "the per-email limits"; the sign-in one is now signInFailuresPerEmailAndIp (RATE_LIMIT_SIGN_IN_FAILURES_PER_EMAIL_AND_IP).
Record the trade-off and the lockout it fixes, and the rejected alternative (email-only key).

Also refresh the stale "per-email limits" comments in deploy/compose.preview.yaml and scripts/assign-dev-rate-limits.sh, and check that no deployed environment still sets the old RATE_LIMIT_SIGN_IN_FAILURES_PER_EMAIL variable (it now falls back silently to the default).

MR !546 (closes #436) changed the sign-in failure counter from lowercased email alone to email and IP together, so strangers can no longer lock a Player out. The owner accepted the trade-off: guesses at one email spread over many IPs are now limited to 5 per IP (each IP still capped by the per-IP limit of 20). ADR 0041 (`docs/adr/0041-rate-limits-are-in-memory-counters-in-the-api.md`) no longer matches the code: - Line 8 says counters are keyed "by IP and by lowercased email"; the sign-in failure counter is now keyed by email and IP together. - Line 12 speaks of "the per-email limits"; the sign-in one is now `signInFailuresPerEmailAndIp` (`RATE_LIMIT_SIGN_IN_FAILURES_PER_EMAIL_AND_IP`). - Record the trade-off and the lockout it fixes, and the rejected alternative (email-only key). Also refresh the stale "per-email limits" comments in `deploy/compose.preview.yaml` and `scripts/assign-dev-rate-limits.sh`, and check that no deployed environment still sets the old `RATE_LIMIT_SIGN_IN_FAILURES_PER_EMAIL` variable (it now falls back silently to the default).

root commented

2026-10-16 07:00:21 +00:00

(Migrated from gitlab.core-project.space)

mentioned in commit fe9f2e3bbb8c9c7f21fad05879afbe9f7de459de

root commented

2026-10-16 07:00:39 +00:00

(Migrated from gitlab.core-project.space)

mentioned in merge request !549