amaurycoudr/chess-project
2
0
Fork 0
Code Issues 5 Pull requests 2 Projects Releases Packages Activity Actions

e2e: harness — create a Room and join it from a second browser #192

New issue
Closed
opened 2026-09-01 13:44:30 +00:00 by root · 9 comments
root commented 2026-09-01 13:44:30 +00:00 (Migrated from gitlab.core-project.space)
Copy link

Imported from GitHub amaurycoudr/chess-project#192, opened by @amaurycoudr on 2026-09-01 13:44 UTC.
Closed on GitHub on 2026-09-01 14:23 UTC as completed.

Parent

#191

What to build

The first crossing of the browser seam, end to end: a Player creates a Room in one browser, a second Player opens the invite link in another browser, and both see the Room's two Seats filled.

This is the tracer bullet for the whole suite, so it carries the harness the later tickets build on. The suite lives in its own workspace package, @chess/e2e, which declares no dependency on the front-end package — that is the mechanism enforcing the seam, not a convention to be remembered.

The suite drives the real front-end and the real API over real SSE Connections. In CI the servers serve built artifacts, so a pass speaks about the bundle a Player actually receives; locally they are the dev servers, for speed, selected by environment variable. Playwright's own web-server support starts both.

Port derivation is mandatory. Dev ports are assigned per worktree in blocks, and the API's configuration loader throws when its port is absent, so the Playwright configuration must load the worktree's environment (or run the repo's port-sync script) and derive its base URL from the assigned front-end port. A hardcoded port would silently drive another worktree's servers and the failure would be baffling.

Each Player is a separate browser context, which gives each its own storage and therefore its own Seat token with no extra machinery. A shared fixture provides a seated pair in a fresh Room.

Two repo prerequisites ride along, both needed before this ticket can be committed at all: the allowed commit scopes must gain e2e, and the Playwright MCP project configuration is committed if it is to be shared (it is an authoring aid only — no committed test may require an MCP server).

Acceptance criteria

  • A new workspace package @chess/e2e exists and its manifest declares no dependency on the front-end package
  • The package implements the Turbo pipeline's existing test:slow task, and does not implement test
  • pnpm test and the pre-commit hook do not run any browser; the five-command gate is unchanged locally
  • A separate CI job runs the suite on pull requests, including a Chromium install step
  • The Playwright base URL is derived from the worktree's assigned front-end port; no port is hardcoded
  • Both the front-end and the API are started by the test run; CI runs against built artifacts, local runs against dev servers, chosen by environment variable
  • Chromium only; no retries; a per-test timeout; focused subsets refused; traces kept on failure
  • A shared fixture yields two independent browser contexts, each with its own storage
  • Green test: Player A creates a Room from the home page, the invite link is taken from A's browser, Player B opens it, and both Players observe two filled Seats
  • The Room used by the test is created through the user interface, not by calling a procedure
  • The package records the selector law: role plus accessible name first; the domain-anchored hooks (board and its orientation, squares by algebraic name, the move list, the captured trays, the per-square selection / legal-target / last-move / check attributes) where no accessible name exists; and the layout-anchored hooks (the rail and its four sub-regions, the room layout wrapper) banned outright
  • No new test hooks are added to the front-end package
  • No test-only procedure is added to the API
  • The allowed commit scopes include e2e
  • All five gate commands pass
> _Imported from GitHub [amaurycoudr/chess-project#192](https://github.com/amaurycoudr/chess-project/issues/192), opened by [@amaurycoudr](https://github.com/amaurycoudr) on 2026-09-01 13:44 UTC._ > _Closed on GitHub on 2026-09-01 14:23 UTC as completed._ <!-- github-issue:192 --> --- ## Parent #191 ## What to build The first crossing of the browser seam, end to end: a Player creates a Room in one browser, a second Player opens the invite link in another browser, and both see the Room's two Seats filled. This is the tracer bullet for the whole suite, so it carries the harness the later tickets build on. The suite lives in its own workspace package, `@chess/e2e`, which declares **no dependency on the front-end package** — that is the mechanism enforcing the seam, not a convention to be remembered. The suite drives the real front-end and the real API over real SSE Connections. In CI the servers serve built artifacts, so a pass speaks about the bundle a Player actually receives; locally they are the dev servers, for speed, selected by environment variable. Playwright's own web-server support starts both. Port derivation is mandatory. Dev ports are assigned per worktree in blocks, and the API's configuration loader throws when its port is absent, so the Playwright configuration must load the worktree's environment (or run the repo's port-sync script) and derive its base URL from the assigned front-end port. A hardcoded port would silently drive another worktree's servers and the failure would be baffling. Each Player is a separate browser context, which gives each its own storage and therefore its own Seat token with no extra machinery. A shared fixture provides a seated pair in a fresh Room. Two repo prerequisites ride along, both needed before this ticket can be committed at all: the allowed commit scopes must gain `e2e`, and the Playwright MCP project configuration is committed if it is to be shared (it is an authoring aid only — no committed test may require an MCP server). ## Acceptance criteria - [ ] A new workspace package `@chess/e2e` exists and its manifest declares no dependency on the front-end package - [ ] The package implements the Turbo pipeline's existing `test:slow` task, and does **not** implement `test` - [ ] `pnpm test` and the pre-commit hook do not run any browser; the five-command gate is unchanged locally - [ ] A separate CI job runs the suite on pull requests, including a Chromium install step - [ ] The Playwright base URL is derived from the worktree's assigned front-end port; no port is hardcoded - [ ] Both the front-end and the API are started by the test run; CI runs against built artifacts, local runs against dev servers, chosen by environment variable - [ ] Chromium only; no retries; a per-test timeout; focused subsets refused; traces kept on failure - [ ] A shared fixture yields two independent browser contexts, each with its own storage - [ ] Green test: Player A creates a Room from the home page, the invite link is taken from A's browser, Player B opens it, and **both** Players observe two filled Seats - [ ] The Room used by the test is created through the user interface, not by calling a procedure - [ ] The package records the selector law: role plus accessible name first; the domain-anchored hooks (board and its orientation, squares by algebraic name, the move list, the captured trays, the per-square selection / legal-target / last-move / check attributes) where no accessible name exists; and the layout-anchored hooks (the rail and its four sub-regions, the room layout wrapper) banned outright - [ ] No new test hooks are added to the front-end package - [ ] No test-only procedure is added to the API - [ ] The allowed commit scopes include `e2e` - [ ] All five gate commands pass
root commented 2026-09-01 13:44:30 +00:00 (Migrated from gitlab.core-project.space)
Copy link

GitHub issue relations, imported as "related" links (GitLab CE has no sub-issues or blocking links).

> _GitHub issue relations, imported as "related" links (GitLab CE has no sub-issues or blocking links)._ <!-- github-relations --> - Blocking: #199, #198, #194, #193
root (Migrated from gitlab.core-project.space) closed this issue 2026-09-01 14:23:32 +00:00
root commented 2026-10-13 08:39:09 +00:00 (Migrated from gitlab.core-project.space)
Copy link

mentioned in issue #193

mentioned in issue #193
root commented 2026-10-13 08:39:09 +00:00 (Migrated from gitlab.core-project.space)
Copy link

mentioned in issue #194

mentioned in issue #194
root commented 2026-10-13 08:39:09 +00:00 (Migrated from gitlab.core-project.space)
Copy link

mentioned in issue #198

mentioned in issue #198
root commented 2026-10-13 08:39:10 +00:00 (Migrated from gitlab.core-project.space)
Copy link

mentioned in issue #199

mentioned in issue #199
root commented 2026-10-13 08:41:45 +00:00 (Migrated from gitlab.core-project.space)
Copy link

marked this issue as related to #199

marked this issue as related to #199
root commented 2026-10-13 08:41:45 +00:00 (Migrated from gitlab.core-project.space)
Copy link

marked this issue as related to #198

marked this issue as related to #198
root commented 2026-10-13 08:41:45 +00:00 (Migrated from gitlab.core-project.space)
Copy link

marked this issue as related to #194

marked this issue as related to #194
root commented 2026-10-13 08:41:45 +00:00 (Migrated from gitlab.core-project.space)
Copy link

marked this issue as related to #193

marked this issue as related to #193
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
ci/forgejo-runner-sizing
docs/contributing-forgejo-ci
fix/storybook-ghsa-f2ph-cmg5-wxc8
prototype/dead-end-page
prototype/puzzles-ui-redesign
prototype/399-front-screens
ci/front-test-one-job
feat/370-drizzle-gateway
pr-screenshots
feat/369-postgres-per-stack
claude/pawn-promotion-capture-score-46fffb
claude/github-workflow-improvements-30cf86
docs/352-adr-claim-guest
docs/351-adr-seat-identity
claude/retro-last-10-conversations-9af723
docs/accounts-adrs
claude/lighthouse-pt-4b5a78
docs/350-adr-sessions
feat/game-status-326
research/postgres-on-vps
research/email-provider
prototype/offer-overlay
ci/339-pr-screenshots
prototype/game-status
ci/317-faster-pipeline
spec/303-vps-hosting
claude/paste-invite-link-room-code
docs/309-adr-vps-hosting
fix/311-client-route-fallback
claude/back-navigation-feature-2166ea
claude/resource-contract
claude/api-nest-orpc
claude/adr-nest-orpc
claude/e2e-tests-new-features-1ce2a1
claude/la-spec-273-fd55ac
claude/matt-pocock-skills-integration-444ba9
chore/adopt-the-cognitive-load-coding-rules-270
feat/choose-the-promotion-piece-in-a-popover-instead-of-auto-queening-267
feat/animate-piece-moves-on-the-board-264
feat/show-drag-state-on-the-board-263
feat/move-a-piece-by-dragging-and-dropping-it-261
feat/blocking-modal-when-the-room-has-closed-246
feat/truthful-opponent-presence-lost-connection-left-new-opponent-248
feat/horizontal-game-and-room-action-bars-with-a-confirmed-leave-247
feat/room-status-block-with-a-fixed-height-and-seat-relative-wording-245
docs/amend-adr-0016-a-vacated-seat-replaces-the-60-second-left-timer-244
feat/lint-against-hard-coded-copy-in-the-front-front-no-literal-copy-252
feat/translate-the-front-with-a-language-provider-english-french-242
docs/adr-front-i18n-paraglide
docs/stacked-prs
fix/render-build-fails-on-corepack-enable-record-the-hosting-adr-240
front/8-lint-error
front/7-local-home-align
front/6-comment-purge
front/5-cache-policy
front/3-dissolve-room-actions
front/4-tests-through-view
front/2-room-restructure
front/1-test-harness
feat/deploy-to-render-free-tier-with-a-preview-per-pr-233
harness/6-coding-standards
harness/5-adrs
harness/4-mechanical-rules
harness/3-drop-sandcastle
harness/2-skill-forks
harness/1-adr-index
claude/e2e-test-sub-agents-f8d06b
claude/e2e-hook-performance-072aa8
e2e-restart
e2e-spectator
e2e-draw-offer
e2e-resign-and-reload
e2e-mate-two-browsers
orchestrate-issue-168-implementation
implement-issue-169-and-pr
orpc-ws-room-feature
home-page-issues
comment-audit-and-rules
local/4-local-rail
local/3-local-board
local/2-design-prep
local/1-engine-accessors
prototype/home-page
prototype/game-screen-layout
worktree-front
chore/worktree-env-and-ports
feat/slice-1-3a-front-store-ws-effect-connection-status-screen-136
fix/143-release-seat-on-disconnect
claude/sandcastle-runner-contract
feat/slice-1-2a-apps-api-skeleton-hono-ws-echo-origin-allowlist-132
feat/slice-1-1-chess-contracts-package-context-md-cleanup-128
refactor/reorganise-src-into-layered-folders-per-adr-0008-123
refactor/refactor-engine-reorganise-src-into-layered-folders-per-adr-0008-123
refactor/introduce-the-piecereader-read-port-118
refactor/move-isattacked-to-attacks-ts-with-board-only-signature-111
feat/slice-b1-zobrist-key-computation-for-positions-99
refactor/slice-a-re-back-squareset-with-split-32-representation-97
sandcastle/sequential-reviewer/1779180017269
feat/san-formatter-core-encoding-moves-captures-en-passant-promotion-castling-92
sandcastle/sequential-reviewer/1779111400188
refactor/engine-pr-10-1-migrate-stalemate-into-a-draw-status-variant-86
sandcastle/sequential-reviewer/1779099667568
feat/engine-pr-9-1-castling-rights-tracking-updatecastlingrights-applymove-wiring-80
refactor/extract-piece-attacks-registry-and-rewire-isattacked-movegen-77
sandcastle/sequential-reviewer/1779027444485
backup/pre-axis-a-rewrite
Labels
Clear labels   
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
spec
Parent spec written by to-spec

  
wayfinder:grilling

   
wayfinder:map

   
wayfinder:prototype

   
wayfinder:research

   
wayfinder:task

   
wontfix
This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
spec
wayfinder:grilling
wayfinder:map
wayfinder:prototype
wayfinder:research
wayfinder:task
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks
#193 e2e: a Game played to checkmate across two browsers
amaurycoudr/chess-project
#194 e2e: resignation, and a reload that preserves the Seat
amaurycoudr/chess-project
#198 e2e: entry paths — typed Room code, unknown code, copied invite
amaurycoudr/chess-project
#199 e2e: opponent presence over an advanced browser clock
amaurycoudr/chess-project
Reference
amaurycoudr/chess-project#192
No description provided.