amaurycoudr/chess-project
2
0
Fork 0
Code Issues 15 Pull requests Projects Releases Packages 1 Activity Actions

Read an Account's profile and its decided Games over the wire, in an ADR superseding 0034 #389

New issue
Closed
opened 2026-10-11 16:27:45 +00:00 by root · 18 comments
root commented 2026-10-11 16:27:45 +00:00 (Migrated from gitlab.core-project.space)
Copy link

Imported from GitHub amaurycoudr/chess-project#389, opened by @amaurycoudr on 2026-10-11 16:27 UTC.

Parent

#366

What to build

Anyone, signed in or not, can read an Account's public profile by username: the username as stored, when the Account joined, and one page of its decided Games, newest first, with a cursor for the next page. A Guest has no profile, and a Game with no Account on either side appears on no profile. The answer carries nothing else about the Account. See #366, Contract, API and ADRs.

First, an ADR superseding ADR 0034 records the one changed decision: an Account's decided Games are listed publicly on its profile, and a Game with no Account owner is listed only to its owner. It restates every other decision of ADR 0034.

Then a new profile router in the contract with one read, profile.get, on a GET route addressed by username, implemented in the games feature module beside "my games":

  • each item reuses the "my games" item shape, with the Color read as the profile Account's, and the page size reuses the "my games" cap;
  • paging is keyset on ended time then id; an unreadable cursor is an input validation error;
  • lookup is case-insensitive; an unknown or deleted username is the new PROFILE_NOT_FOUND refusal (404), in the refusal status table and the controller's refusal table;
  • the read is public: it opts out of the auth guard, never reads a Session or a Guest, and passes the origin guard without an Origin (ADR 0028);
  • it reads the Account owner columns only, never joining through claimed Guests (ADR 0035).

Seam: The RPC wire

Acceptance criteria

  • A new ADR, status accepted, in the repo's ADR format, supersedes ADR 0034 and restates its surviving decisions; ADR 0034's Status reads superseded by it and nothing else in 0034 changes; the ADR index has the new row with precise Governs globs and 0034's row turned to superseded
  • The GLOSSARY and code comments that point at ADR 0034 for a surviving decision point at the new ADR
  • The profile read answers the username as stored, the join time, and the Account's decided Games newest first, each with the Account's Color, the winner, the ending and the opponent's name
  • A claimed Guest's Games are listed, including one decided after the claim for a Seat the Guest still held
  • A Game between two Guests appears on no profile; an Account's opponent who is a Guest, an Account or no one (a vacated Seat) each comes out as such
  • A self-game is listed once
  • The answer is identical with and without a Session or a Guest header, and never holds an email or any other Account field
  • An unknown username, a deleted Account and a username with characters outside the allowed set are each refused as not found, not as a validation error; a username in another case finds the Account
  • An Account with no Games answers an empty page with no cursor; exactly one page answers no cursor; one more than a page answers a cursor whose next page holds the last Game
  • A Game decided between two page reads is neither repeated nor skipped; an unreadable cursor is an input validation error
  • Each result and ending reads correctly from either Color
  • The gate is green
  • The ADR is this ticket's first commit, before any code it governs
> _Imported from GitHub [amaurycoudr/chess-project#389](https://github.com/amaurycoudr/chess-project/issues/389), opened by [@amaurycoudr](https://github.com/amaurycoudr) on 2026-10-11 16:27 UTC._ <!-- github-issue:389 --> --- ## Parent #366 ## What to build Anyone, signed in or not, can read an **Account**'s public profile by username: the username as stored, when the **Account** joined, and one page of its decided **Games**, newest first, with a cursor for the next page. A **Guest** has no profile, and a **Game** with no **Account** on either side appears on no profile. The answer carries nothing else about the **Account**. See #366, *Contract*, *API* and *ADRs*. First, an ADR superseding ADR 0034 records the one changed decision: an **Account**'s decided **Games** are listed publicly on its profile, and a **Game** with no **Account** owner is listed only to its owner. It restates every other decision of ADR 0034. Then a new `profile` router in the contract with one read, `profile.get`, on a GET route addressed by username, implemented in the games feature module beside "my games": - each item reuses the "my games" item shape, with the **Color** read as the profile **Account**'s, and the page size reuses the "my games" cap; - paging is keyset on ended time then id; an unreadable cursor is an input validation error; - lookup is case-insensitive; an unknown or deleted username is the new `PROFILE_NOT_FOUND` refusal (404), in the refusal status table and the controller's refusal table; - the read is public: it opts out of the auth guard, never reads a **Session** or a **Guest**, and passes the origin guard without an Origin (ADR 0028); - it reads the **Account** owner columns only, never joining through claimed **Guests** (ADR 0035). Seam: The RPC wire ## Acceptance criteria - [ ] A new ADR, status accepted, in the repo's ADR format, supersedes ADR 0034 and restates its surviving decisions; ADR 0034's Status reads superseded by it and nothing else in 0034 changes; the ADR index has the new row with precise Governs globs and 0034's row turned to superseded - [ ] The GLOSSARY and code comments that point at ADR 0034 for a surviving decision point at the new ADR - [ ] The profile read answers the username as stored, the join time, and the **Account**'s decided **Games** newest first, each with the **Account**'s **Color**, the winner, the ending and the opponent's name - [ ] A claimed **Guest**'s **Games** are listed, including one decided after the claim for a **Seat** the **Guest** still held - [ ] A **Game** between two **Guests** appears on no profile; an **Account**'s opponent who is a **Guest**, an **Account** or no one (a vacated **Seat**) each comes out as such - [ ] A self-game is listed once - [ ] The answer is identical with and without a **Session** or a **Guest** header, and never holds an email or any other **Account** field - [ ] An unknown username, a deleted **Account** and a username with characters outside the allowed set are each refused as not found, not as a validation error; a username in another case finds the **Account** - [ ] An **Account** with no **Games** answers an empty page with no cursor; exactly one page answers no cursor; one more than a page answers a cursor whose next page holds the last **Game** - [ ] A **Game** decided between two page reads is neither repeated nor skipped; an unreadable cursor is an input validation error - [ ] Each result and ending reads correctly from either **Color** - [ ] The gate is green - [ ] The ADR is this ticket's first commit, before any code it governs
root commented 2026-10-11 16:27:45 +00:00 (Migrated from gitlab.core-project.space)
Copy link

GitHub issue relations, imported as "related" links (GitLab CE has no sub-issues or blocking links).

> _GitHub issue relations, imported as "related" links (GitLab CE has no sub-issues or blocking links)._ <!-- github-relations --> - Parent (sub-issue of): #366 - Blocked by: #388, #386 - Blocking: #390
root commented 2026-10-13 08:39:52 +00:00 (Migrated from gitlab.core-project.space)
Copy link

mentioned in issue #390

mentioned in issue #390
root commented 2026-10-13 08:41:23 +00:00 (Migrated from gitlab.core-project.space)
Copy link

mentioned in issue #366

mentioned in issue #366
root commented 2026-10-13 08:41:29 +00:00 (Migrated from gitlab.core-project.space)
Copy link

mentioned in issue #386

mentioned in issue #386
root commented 2026-10-13 08:41:30 +00:00 (Migrated from gitlab.core-project.space)
Copy link

mentioned in issue #388

mentioned in issue #388
root commented 2026-10-13 08:42:31 +00:00 (Migrated from gitlab.core-project.space)
Copy link

marked this issue as related to #366

marked this issue as related to #366
root commented 2026-10-13 08:42:42 +00:00 (Migrated from gitlab.core-project.space)
Copy link

marked this issue as related to #386

marked this issue as related to #386
root commented 2026-10-13 08:42:43 +00:00 (Migrated from gitlab.core-project.space)
Copy link

marked this issue as related to #388

marked this issue as related to #388
root commented 2026-10-13 08:42:43 +00:00 (Migrated from gitlab.core-project.space)
Copy link

marked this issue as related to #390

marked this issue as related to #390
root commented 2026-10-15 09:22:54 +00:00 (Migrated from gitlab.core-project.space)
Copy link

mentioned in commit db9e1fdf59

mentioned in commit db9e1fdf59979914f98512e640997a6531124592
root commented 2026-10-15 09:22:54 +00:00 (Migrated from gitlab.core-project.space)
Copy link

mentioned in commit d90d1c04a4

mentioned in commit d90d1c04a4fdaad3429326475fe9baf1223c3520
root commented 2026-10-15 09:22:54 +00:00 (Migrated from gitlab.core-project.space)
Copy link

mentioned in commit 4c3398c3c2

mentioned in commit 4c3398c3c269f8af6ae4f65bb7df504766a00456
root commented 2026-10-15 09:22:54 +00:00 (Migrated from gitlab.core-project.space)
Copy link

mentioned in commit 26a3ed3b6a

mentioned in commit 26a3ed3b6ac53ce3568535a5c6189f9dead56547
root commented 2026-10-15 09:22:55 +00:00 (Migrated from gitlab.core-project.space)
Copy link

mentioned in commit 0cb053dbe9

mentioned in commit 0cb053dbe9ea81eb8289e0e6bd923455e1bcb61f
root commented 2026-10-15 09:22:55 +00:00 (Migrated from gitlab.core-project.space)
Copy link

mentioned in commit 92db661c71

mentioned in commit 92db661c7195febb26f2774d2c32446147c4531f
root commented 2026-10-15 09:22:55 +00:00 (Migrated from gitlab.core-project.space)
Copy link

mentioned in commit 3ac3237f08

mentioned in commit 3ac3237f08e27eb8495e39846cf0c4fa2a00a6b3
root commented 2026-10-15 09:22:56 +00:00 (Migrated from gitlab.core-project.space)
Copy link

mentioned in commit febccf71f7

mentioned in commit febccf71f7fe7837475351786c312562b568b9f9
root commented 2026-10-15 09:23:10 +00:00 (Migrated from gitlab.core-project.space)
Copy link

mentioned in merge request !531

mentioned in merge request !531
root (Migrated from gitlab.core-project.space) closed this issue 2026-10-15 09:44:36 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
fix/front-browser-pages
docs/contributing-forgejo-ci
fix/storybook-ghsa-f2ph-cmg5-wxc8
prototype/dead-end-page
prototype/puzzles-ui-redesign
prototype/399-front-screens
ci/front-test-one-job
feat/370-drizzle-gateway
pr-screenshots
feat/369-postgres-per-stack
claude/pawn-promotion-capture-score-46fffb
claude/github-workflow-improvements-30cf86
docs/352-adr-claim-guest
docs/351-adr-seat-identity
claude/retro-last-10-conversations-9af723
docs/accounts-adrs
claude/lighthouse-pt-4b5a78
docs/350-adr-sessions
feat/game-status-326
research/postgres-on-vps
research/email-provider
prototype/offer-overlay
ci/339-pr-screenshots
prototype/game-status
ci/317-faster-pipeline
spec/303-vps-hosting
claude/paste-invite-link-room-code
docs/309-adr-vps-hosting
fix/311-client-route-fallback
claude/back-navigation-feature-2166ea
claude/resource-contract
claude/api-nest-orpc
claude/adr-nest-orpc
claude/e2e-tests-new-features-1ce2a1
claude/la-spec-273-fd55ac
claude/matt-pocock-skills-integration-444ba9
chore/adopt-the-cognitive-load-coding-rules-270
feat/choose-the-promotion-piece-in-a-popover-instead-of-auto-queening-267
feat/animate-piece-moves-on-the-board-264
feat/show-drag-state-on-the-board-263
feat/move-a-piece-by-dragging-and-dropping-it-261
feat/blocking-modal-when-the-room-has-closed-246
feat/truthful-opponent-presence-lost-connection-left-new-opponent-248
feat/horizontal-game-and-room-action-bars-with-a-confirmed-leave-247
feat/room-status-block-with-a-fixed-height-and-seat-relative-wording-245
docs/amend-adr-0016-a-vacated-seat-replaces-the-60-second-left-timer-244
feat/lint-against-hard-coded-copy-in-the-front-front-no-literal-copy-252
feat/translate-the-front-with-a-language-provider-english-french-242
docs/adr-front-i18n-paraglide
docs/stacked-prs
fix/render-build-fails-on-corepack-enable-record-the-hosting-adr-240
front/8-lint-error
front/7-local-home-align
front/6-comment-purge
front/5-cache-policy
front/3-dissolve-room-actions
front/4-tests-through-view
front/2-room-restructure
front/1-test-harness
feat/deploy-to-render-free-tier-with-a-preview-per-pr-233
harness/6-coding-standards
harness/5-adrs
harness/4-mechanical-rules
harness/3-drop-sandcastle
harness/2-skill-forks
harness/1-adr-index
claude/e2e-test-sub-agents-f8d06b
claude/e2e-hook-performance-072aa8
e2e-restart
e2e-spectator
e2e-draw-offer
e2e-resign-and-reload
e2e-mate-two-browsers
orchestrate-issue-168-implementation
implement-issue-169-and-pr
orpc-ws-room-feature
home-page-issues
comment-audit-and-rules
local/4-local-rail
local/3-local-board
local/2-design-prep
local/1-engine-accessors
prototype/home-page
prototype/game-screen-layout
worktree-front
chore/worktree-env-and-ports
feat/slice-1-3a-front-store-ws-effect-connection-status-screen-136
fix/143-release-seat-on-disconnect
claude/sandcastle-runner-contract
feat/slice-1-2a-apps-api-skeleton-hono-ws-echo-origin-allowlist-132
feat/slice-1-1-chess-contracts-package-context-md-cleanup-128
refactor/reorganise-src-into-layered-folders-per-adr-0008-123
refactor/refactor-engine-reorganise-src-into-layered-folders-per-adr-0008-123
refactor/introduce-the-piecereader-read-port-118
refactor/move-isattacked-to-attacks-ts-with-board-only-signature-111
feat/slice-b1-zobrist-key-computation-for-positions-99
refactor/slice-a-re-back-squareset-with-split-32-representation-97
sandcastle/sequential-reviewer/1779180017269
feat/san-formatter-core-encoding-moves-captures-en-passant-promotion-castling-92
sandcastle/sequential-reviewer/1779111400188
refactor/engine-pr-10-1-migrate-stalemate-into-a-draw-status-variant-86
sandcastle/sequential-reviewer/1779099667568
feat/engine-pr-9-1-castling-rights-tracking-updatecastlingrights-applymove-wiring-80
refactor/extract-piece-attacks-registry-and-rewire-isattacked-movegen-77
sandcastle/sequential-reviewer/1779027444485
backup/pre-axis-a-rewrite
Labels
Clear labels   
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
spec
Parent spec written by to-spec

  
wayfinder:grilling

   
wayfinder:map

   
wayfinder:prototype

   
wayfinder:research

   
wayfinder:task

   
wontfix
This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
spec
wayfinder:grilling
wayfinder:map
wayfinder:prototype
wayfinder:research
wayfinder:task
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks
#390 Open an Account's profile at /players/<username>: rows, show more, empty and not-found
amaurycoudr/chess-project
Depends on
#386 Show a self-game once, with both sides as You
amaurycoudr/chess-project
#388 Offer the claim at sign-up and after sign-in
amaurycoudr/chess-project
Reference
amaurycoudr/chess-project#389
No description provided.