amaurycoudr/chess-project
2
0
Fork 0
Code Issues 15 Pull requests Projects Releases Packages 1 Activity Actions

Merge each route's view and UI into one page file #415

New issue
Closed
opened 2026-10-15 12:33:53 +00:00 by root · 9 comments
root commented 2026-10-15 12:33:53 +00:00 (Migrated from gitlab.core-project.space)
Copy link

Parent

#408

What to build

Each of the 13 route pages is one page file holding its hooks, mutations and layout, instead of a view and a UI file. Routes import their page and their not-found screen directly, and the wrapper views that existed only for the route import rule go. Every screen looks and behaves exactly as before.

Seam: S2 — every existing front view test, unchanged in what it asserts.

Acceptance criteria

  • No .view.tsx or .ui.tsx file remains; 13 page files replace 26 files.
  • Layout pieces reused elsewhere stay in components/.
  • Routes import the not-found screens directly; the wrapper views are gone.
  • Every existing view test passes, changed only in its imports.
  • Lint and the gate are green.
## Parent #408 ## What to build Each of the 13 route pages is one page file holding its hooks, mutations and layout, instead of a view and a UI file. Routes import their page and their not-found screen directly, and the wrapper views that existed only for the route import rule go. Every screen looks and behaves exactly as before. Seam: S2 — every existing front view test, unchanged in what it asserts. ## Acceptance criteria - [ ] No `.view.tsx` or `.ui.tsx` file remains; 13 page files replace 26 files. - [ ] Layout pieces reused elsewhere stay in `components/`. - [ ] Routes import the not-found screens directly; the wrapper views are gone. - [ ] Every existing view test passes, changed only in its imports. - [ ] Lint and the gate are green.
root commented 2026-10-15 12:33:53 +00:00 (Migrated from gitlab.core-project.space)
Copy link

marked this issue as related to #408

marked this issue as related to #408
root commented 2026-10-15 12:33:54 +00:00 (Migrated from gitlab.core-project.space)
Copy link

marked this issue as related to #414

marked this issue as related to #414
root commented 2026-10-15 12:34:07 +00:00 (Migrated from gitlab.core-project.space)
Copy link

mentioned in issue #416

mentioned in issue #416
root commented 2026-10-15 12:34:08 +00:00 (Migrated from gitlab.core-project.space)
Copy link

marked this issue as related to #416

marked this issue as related to #416
root commented 2026-10-15 12:34:09 +00:00 (Migrated from gitlab.core-project.space)
Copy link

mentioned in issue #417

mentioned in issue #417
root commented 2026-10-15 12:34:09 +00:00 (Migrated from gitlab.core-project.space)
Copy link

marked this issue as related to #417

marked this issue as related to #417
root commented 2026-10-15 13:17:12 +00:00 (Migrated from gitlab.core-project.space)
Copy link

mentioned in merge request !534

mentioned in merge request !534
root commented 2026-10-15 13:27:14 +00:00 (Migrated from gitlab.core-project.space)
Copy link

mentioned in commit 7e2d65c99f

mentioned in commit 7e2d65c99fbefc639429af08f29381aac0d8adbf
root commented 2026-10-15 14:14:07 +00:00 (Migrated from gitlab.core-project.space)
Copy link

mentioned in commit 30b3ae6008

mentioned in commit 30b3ae60088885819c7c12403ce4c1db39ab7c94
root (Migrated from gitlab.core-project.space) closed this issue 2026-10-15 15:17:48 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
fix/front-browser-pages
docs/contributing-forgejo-ci
fix/storybook-ghsa-f2ph-cmg5-wxc8
prototype/dead-end-page
prototype/puzzles-ui-redesign
prototype/399-front-screens
ci/front-test-one-job
feat/370-drizzle-gateway
pr-screenshots
feat/369-postgres-per-stack
claude/pawn-promotion-capture-score-46fffb
claude/github-workflow-improvements-30cf86
docs/352-adr-claim-guest
docs/351-adr-seat-identity
claude/retro-last-10-conversations-9af723
docs/accounts-adrs
claude/lighthouse-pt-4b5a78
docs/350-adr-sessions
feat/game-status-326
research/postgres-on-vps
research/email-provider
prototype/offer-overlay
ci/339-pr-screenshots
prototype/game-status
ci/317-faster-pipeline
spec/303-vps-hosting
claude/paste-invite-link-room-code
docs/309-adr-vps-hosting
fix/311-client-route-fallback
claude/back-navigation-feature-2166ea
claude/resource-contract
claude/api-nest-orpc
claude/adr-nest-orpc
claude/e2e-tests-new-features-1ce2a1
claude/la-spec-273-fd55ac
claude/matt-pocock-skills-integration-444ba9
chore/adopt-the-cognitive-load-coding-rules-270
feat/choose-the-promotion-piece-in-a-popover-instead-of-auto-queening-267
feat/animate-piece-moves-on-the-board-264
feat/show-drag-state-on-the-board-263
feat/move-a-piece-by-dragging-and-dropping-it-261
feat/blocking-modal-when-the-room-has-closed-246
feat/truthful-opponent-presence-lost-connection-left-new-opponent-248
feat/horizontal-game-and-room-action-bars-with-a-confirmed-leave-247
feat/room-status-block-with-a-fixed-height-and-seat-relative-wording-245
docs/amend-adr-0016-a-vacated-seat-replaces-the-60-second-left-timer-244
feat/lint-against-hard-coded-copy-in-the-front-front-no-literal-copy-252
feat/translate-the-front-with-a-language-provider-english-french-242
docs/adr-front-i18n-paraglide
docs/stacked-prs
fix/render-build-fails-on-corepack-enable-record-the-hosting-adr-240
front/8-lint-error
front/7-local-home-align
front/6-comment-purge
front/5-cache-policy
front/3-dissolve-room-actions
front/4-tests-through-view
front/2-room-restructure
front/1-test-harness
feat/deploy-to-render-free-tier-with-a-preview-per-pr-233
harness/6-coding-standards
harness/5-adrs
harness/4-mechanical-rules
harness/3-drop-sandcastle
harness/2-skill-forks
harness/1-adr-index
claude/e2e-test-sub-agents-f8d06b
claude/e2e-hook-performance-072aa8
e2e-restart
e2e-spectator
e2e-draw-offer
e2e-resign-and-reload
e2e-mate-two-browsers
orchestrate-issue-168-implementation
implement-issue-169-and-pr
orpc-ws-room-feature
home-page-issues
comment-audit-and-rules
local/4-local-rail
local/3-local-board
local/2-design-prep
local/1-engine-accessors
prototype/home-page
prototype/game-screen-layout
worktree-front
chore/worktree-env-and-ports
feat/slice-1-3a-front-store-ws-effect-connection-status-screen-136
fix/143-release-seat-on-disconnect
claude/sandcastle-runner-contract
feat/slice-1-2a-apps-api-skeleton-hono-ws-echo-origin-allowlist-132
feat/slice-1-1-chess-contracts-package-context-md-cleanup-128
refactor/reorganise-src-into-layered-folders-per-adr-0008-123
refactor/refactor-engine-reorganise-src-into-layered-folders-per-adr-0008-123
refactor/introduce-the-piecereader-read-port-118
refactor/move-isattacked-to-attacks-ts-with-board-only-signature-111
feat/slice-b1-zobrist-key-computation-for-positions-99
refactor/slice-a-re-back-squareset-with-split-32-representation-97
sandcastle/sequential-reviewer/1779180017269
feat/san-formatter-core-encoding-moves-captures-en-passant-promotion-castling-92
sandcastle/sequential-reviewer/1779111400188
refactor/engine-pr-10-1-migrate-stalemate-into-a-draw-status-variant-86
sandcastle/sequential-reviewer/1779099667568
feat/engine-pr-9-1-castling-rights-tracking-updatecastlingrights-applymove-wiring-80
refactor/extract-piece-attacks-registry-and-rewire-isattacked-movegen-77
sandcastle/sequential-reviewer/1779027444485
backup/pre-axis-a-rewrite
Labels
Clear labels   
bug
Something isn't working

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
question
Further information is requested

  
spec
Parent spec written by to-spec

  
wayfinder:grilling

   
wayfinder:map

   
wayfinder:prototype

   
wayfinder:research

   
wayfinder:task

   
wontfix
This will not be worked on

No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
spec
wayfinder:grilling
wayfinder:map
wayfinder:prototype
wayfinder:research
wayfinder:task
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks
#416 Group the Room's services by concept and merge its announcement hooks
amaurycoudr/chess-project
#417 Render view tests on the app's own route tree
amaurycoudr/chess-project
Depends on
#414 Rewrite the front's rules and ADR 0011 as the owner decided
amaurycoudr/chess-project
Reference
amaurycoudr/chess-project#415
No description provided.