Group the Room's services by concept and merge its announcement hooks #416

Closed
opened 2026-10-15 12:34:07 +00:00 by root · 5 comments
root commented 2026-10-15 12:34:07 +00:00 (Migrated from gitlab.core-project.space)

Parent

#408

What to build

The Room vertical's services hold one concept per file: the Room query with its invalidation, the Room's mutations (create, leave, resign, offers), the Move on its own, entering a Room, and refusals with their toast and write handler. The two announcement hooks become one. A Room plays exactly as before.

Seam: S2 — every existing Room view test, unchanged in what it asserts.

Acceptance criteria

  • room/services/ drops from 11 files to 5, and room/hooks/ from 6 to 5.
  • The Move's mutation stays alone in its file, so its setQueryData lint exception stays as narrow as today (ADR 0019).
  • Every existing Room test passes, changed only in its imports.
  • Lint and the gate are green.
## Parent #408 ## What to build The Room vertical's services hold one concept per file: the Room query with its invalidation, the Room's mutations (create, leave, resign, offers), the Move on its own, entering a Room, and refusals with their toast and write handler. The two announcement hooks become one. A Room plays exactly as before. Seam: S2 — every existing Room view test, unchanged in what it asserts. ## Acceptance criteria - [ ] `room/services/` drops from 11 files to 5, and `room/hooks/` from 6 to 5. - [ ] The Move's mutation stays alone in its file, so its `setQueryData` lint exception stays as narrow as today (ADR 0019). - [ ] Every existing Room test passes, changed only in its imports. - [ ] Lint and the gate are green.
root commented 2026-10-15 12:34:07 +00:00 (Migrated from gitlab.core-project.space)

marked this issue as related to #408

marked this issue as related to #408
root commented 2026-10-15 12:34:07 +00:00 (Migrated from gitlab.core-project.space)

marked this issue as related to #415

marked this issue as related to #415
root commented 2026-10-15 13:17:12 +00:00 (Migrated from gitlab.core-project.space)

mentioned in merge request !534

mentioned in merge request !534
root commented 2026-10-15 13:30:23 +00:00 (Migrated from gitlab.core-project.space)

mentioned in commit 7263e9087d

mentioned in commit 7263e9087d505beba0643099dc61879d2c88a547
root commented 2026-10-15 14:14:07 +00:00 (Migrated from gitlab.core-project.space)

mentioned in commit 1369dbd823

mentioned in commit 1369dbd823097352a56855399c4d87903d3dcf0d
root (Migrated from gitlab.core-project.space) closed this issue 2026-10-15 15:17:48 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference
amaurycoudr/chess-project#416
No description provided.