Guest as plain functions: no GuestService, no global Guest module, the oRPC module imported once #424

New issue

Closed

opened 2026-10-15 14:45:20 +00:00 by root · 7 comments

root commented

2026-10-15 14:45:20 +00:00

(Migrated from gitlab.core-project.space)

Parent

#421

What to build

Guest code becomes plain functions, and the global module that existed only to share a stateless service goes away.

A framework-free file in common/, named after Guest, holds the occupant types, the occupant of a Guest (its hash) and the comparison of two occupants.
GuestService and its global module are deleted.
The RPC context computes a Guest's occupant with the plain function; its content is unchanged.
The Room service compares occupants with the plain function.
Minting a Guest stays a Room service option until the minters ticket.
The oRPC module is imported once, at the root, instead of by each feature module.

Players see no change: arriving in a Room, taking a Seat and claiming a Guest behave as before (ADR 0042, 0035).

Seam: S2, the Room through its services; S1, the wire; S3, the lint.

Acceptance criteria

No GuestService and no Guest module remain. The Guest file imports no framework, and the lint test says so.
Room and Play services are built in the Room fixtures without a Guest service. A test can still fix the minted Guest.
The oRPC module is imported once, at the root.
The Room tests and the RPC integration tests pass unchanged in what they assert.

## Parent #421 ## What to build Guest code becomes plain functions, and the global module that existed only to share a stateless service goes away. - A framework-free file in `common/`, named after Guest, holds the occupant types, the occupant of a Guest (its hash) and the comparison of two occupants. - `GuestService` and its global module are deleted. - The RPC context computes a Guest's occupant with the plain function; its content is unchanged. - The Room service compares occupants with the plain function. - Minting a Guest stays a Room service option until the minters ticket. - The oRPC module is imported once, at the root, instead of by each feature module. Players see no change: arriving in a Room, taking a Seat and claiming a Guest behave as before (ADR 0042, 0035). Seam: S2, the Room through its services; S1, the wire; S3, the lint. ## Acceptance criteria - [ ] No `GuestService` and no Guest module remain. The Guest file imports no framework, and the lint test says so. - [ ] Room and Play services are built in the Room fixtures without a Guest service. A test can still fix the minted Guest. - [ ] The oRPC module is imported once, at the root. - [ ] The Room tests and the RPC integration tests pass unchanged in what they assert.

root commented

2026-10-15 14:45:27 +00:00

(Migrated from gitlab.core-project.space)

mentioned in issue #425