Static feature modules, a root options module and token overrides in createApp #425

New issue

Closed

opened 2026-10-15 14:45:27 +00:00 by root · 11 comments

root commented

2026-10-15 14:45:27 +00:00

(Migrated from gitlab.core-project.space)

Parent

#421

What to build

Feature modules declare their dependencies, configuration enters the app in one place, and tests replace providers by token instead of through production options.

The Auth, Games, Room, Mail and Database modules become static and declare their imports: Room imports Games, Games imports Auth, Auth imports Mail.
A global options module, built by the root module from the app options, provides every feature's option tokens once. Each token stays defined in its feature.
The Database module reads its source from a token.
The devtools module is static. It is added to the root's imports only on stacks that enable devtools (ADR 0039).
The app options keep only production configuration: allowed origins, database source, session secret, public URL, mail, rate limits, devtools flag, Mailpit URL, front dist directory.
createApp takes an optional second argument, a list of { token, value } pairs applied as provider overrides before the app boots.
The test fixture's connect() passes overrides there. Tests that passed per-feature options (Rooms, Auth, Games, Guests) override the option tokens instead.

Room's factories that turn Games into its isClaimed and onDecided callbacks stay as they are. No configured module object is passed from one module to another.

Seam: S1, the wire through the real app.

Acceptance criteria

Only the root module is dynamic. Every feature module lists what it imports, and no forRoot receives another module.
One Auth service and one Games service exist per app.
The app options type holds no test-only field (no sweep scheduler, hash cost, clock or random source).
createApp applies token overrides before boot. connect() uses them for the sweep scheduler, the hash cost and every former per-feature option.
Devtools procedures exist only when devtools are enabled, as today.
Every API test passes, changed only in how it builds the app.

## Parent #421 ## What to build Feature modules declare their dependencies, configuration enters the app in one place, and tests replace providers by token instead of through production options. - The Auth, Games, Room, Mail and Database modules become static and declare their imports: Room imports Games, Games imports Auth, Auth imports Mail. - A global options module, built by the root module from the app options, provides every feature's option tokens once. Each token stays defined in its feature. - The Database module reads its source from a token. - The devtools module is static. It is added to the root's imports only on stacks that enable devtools (ADR 0039). - The app options keep only production configuration: allowed origins, database source, session secret, public URL, mail, rate limits, devtools flag, Mailpit URL, front dist directory. - `createApp` takes an optional second argument, a list of `{ token, value }` pairs applied as provider overrides before the app boots. - The test fixture's `connect()` passes overrides there. Tests that passed per-feature options (Rooms, Auth, Games, Guests) override the option tokens instead. Room's factories that turn Games into its `isClaimed` and `onDecided` callbacks stay as they are. No configured module object is passed from one module to another. Seam: S1, the wire through the real app. ## Acceptance criteria - [ ] Only the root module is dynamic. Every feature module lists what it imports, and no `forRoot` receives another module. - [ ] One Auth service and one Games service exist per app. - [ ] The app options type holds no test-only field (no sweep scheduler, hash cost, clock or random source). - [ ] `createApp` applies token overrides before boot. `connect()` uses them for the sweep scheduler, the hash cost and every former per-feature option. - [ ] Devtools procedures exist only when devtools are enabled, as today. - [ ] Every API test passes, changed only in how it builds the app.

root commented

2026-10-15 14:45:39 +00:00

(Migrated from gitlab.core-project.space)

mentioned in issue #426