One minter per kind of identity: Room code, Game id, Guest, secret #428

New issue

Closed

opened 2026-10-15 14:45:47 +00:00 by root · 5 comments

root commented

2026-10-15 14:45:47 +00:00

(Migrated from gitlab.core-project.space)

Parent

#421

What to build

Each kind of identity the API mints comes from its own provider, so a test fixes one kind without touching the others.

Four minters:
- Room code (room);
- Game id (games);
- Guest (common/, beside the Guest functions);
- secret for Sessions, refresh tokens and reset links (common/).
Each minter is a provider defined by its owning feature, defaulting to randomBytes or Math.random, and injected in place of the random, randomBytes and mintGuest options.
The Room fixtures pass the Room-code and Guest minters directly.

After this ticket, rule 2 as rewritten by the rules ticket holds everywhere.

Blocked by the clock ticket only because both rewrite the same constructors.

Seam: S1, the wire; S2, the Room through its services.

Acceptance criteria

No service takes random, randomBytes or mintGuest. Each injects the minter it uses.
Only minter defaults call randomBytes or Math.random in the API.
A new integration test forces a Game-id collision and shows two Guests minted in the same test as distinct.
The Room-code collision, Game-id collision and fixed-Guest tests pass, changed only in how they fix the value.

## Parent #421 ## What to build Each kind of identity the API mints comes from its own provider, so a test fixes one kind without touching the others. - Four minters: - Room code (room); - Game id (games); - Guest (`common/`, beside the Guest functions); - secret for Sessions, refresh tokens and reset links (`common/`). - Each minter is a provider defined by its owning feature, defaulting to `randomBytes` or `Math.random`, and injected in place of the `random`, `randomBytes` and `mintGuest` options. - The Room fixtures pass the Room-code and Guest minters directly. After this ticket, rule 2 as rewritten by the rules ticket holds everywhere. Blocked by the clock ticket only because both rewrite the same constructors. Seam: S1, the wire; S2, the Room through its services. ## Acceptance criteria - [ ] No service takes `random`, `randomBytes` or `mintGuest`. Each injects the minter it uses. - [ ] Only minter defaults call `randomBytes` or `Math.random` in the API. - [ ] A new integration test forces a Game-id collision and shows two Guests minted in the same test as distinct. - [ ] The Room-code collision, Game-id collision and fixed-Guest tests pass, changed only in how they fix the value.

root commented

2026-10-15 14:46:11 +00:00

(Migrated from gitlab.core-project.space)

marked this issue as related to #421