ci: drop the browser suite against the preview, which e2e already runs #510
No reviewers
Labels
No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
spec
wayfinder:grilling
wayfinder:map
wayfinder:prototype
wayfinder:research
wayfinder:task
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
amaurycoudr/chess-project!510
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "ci/drop-review-e2e"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
The browser suite ran twice on every merge request: once against servers built in the job (
e2e), once against the deployed preview (review-e2e). Once each stack has its own Postgres (!506), the second would write its test rooms into the preview's real database.e2ekeeps a throwaway one.The
deployedtarget stays inapps/e2efor the screenshots (#392). Decision logged ininfra/gitlab/DECISIONS.md, "CI speed-up". The local PoC variant (infra/gitlab/ci/) loses the job too, along with the CA artifact only it read.Evidence
review-e2ewas the second-longest job: 138 s run, afterreview, at the end of the deploy chain.After: pipeline 13 (this MR): no
review-e2e; the deploy chain ends atreview. Total job time 664 s against about 875 s; 431 s from the first job's start to the last job's end, against 567 s. (It waited 868 s for a slot behind other pipelines, so wall time from creation says nothing here.)Merge Danger
Door: two-way
Reverting the commit brings the job back.
Blast Radius: coverage
No browser suite checks a preview once it is deployed.
reviewstill runsdeploy/verify.shagainst it (health, origin check, noindex), ande2ecovers the app.mentioned in merge request !512
changed the description
added 3 commits
mainCompare with previous version
added 3 commits
maina84b494b- ci: drop the browser suite against the preview, which e2e already runsCompare with previous version