ci: drop the browser suite against the preview, which e2e already runs #510

Merged
project_1_bot_05dcee5cd59f879ab35191d664847a9d merged 1 commit from ci/drop-review-e2e into main 2026-10-13 12:50:34 +00:00
project_1_bot_05dcee5cd59f879ab35191d664847a9d commented 2026-10-13 12:14:06 +00:00 (Migrated from gitlab.core-project.space)

Summary

The browser suite ran twice on every merge request: once against servers built in the job (e2e), once against the deployed preview (review-e2e). Once each stack has its own Postgres (!506), the second would write its test rooms into the preview's real database. e2e keeps a throwaway one.

 MR pipeline
   changes
   checks
   front-test 1/3, 2/3, 3/3
   e2e                                  # the suite, servers built in the job
   build-workspace → build-image → review
-                                     → review-e2e   # the same 35 tests, against pr-<n>

The deployed target stays in apps/e2e for the screenshots (#392). Decision logged in infra/gitlab/DECISIONS.md, "CI speed-up". The local PoC variant (infra/gitlab/ci/) loses the job too, along with the CA artifact only it read.

Evidence

  • Before: pipeline 9 (!506). review-e2e was the second-longest job: 138 s run, after review, at the end of the deploy chain.
    After: pipeline 13 (this MR): no review-e2e; the deploy chain ends at review. Total job time 664 s against about 875 s; 431 s from the first job's start to the last job's end, against 567 s. (It waited 868 s for a slot behind other pipelines, so wall time from creation says nothing here.)

Merge Danger

Door: two-way

Reverting the commit brings the job back.

Blast Radius: coverage

No browser suite checks a preview once it is deployed. review still runs deploy/verify.sh against it (health, origin check, noindex), and e2e covers the app.

## Summary The browser suite ran twice on every merge request: once against servers built in the job (`e2e`), once against the deployed preview (`review-e2e`). Once each stack has its own Postgres (!506), the second would write its test rooms into the preview's real database. `e2e` keeps a throwaway one. ```diff MR pipeline changes checks front-test 1/3, 2/3, 3/3 e2e # the suite, servers built in the job build-workspace → build-image → review - → review-e2e # the same 35 tests, against pr-<n> ``` The `deployed` target stays in `apps/e2e` for the screenshots (#392). Decision logged in `infra/gitlab/DECISIONS.md`, "CI speed-up". The local PoC variant (`infra/gitlab/ci/`) loses the job too, along with the CA artifact only it read. ## Evidence - **Before:** pipeline 9 (!506). `review-e2e` was the second-longest job: 138 s run, after `review`, at the end of the deploy chain. **After:** pipeline 13 (this MR): no `review-e2e`; the deploy chain ends at `review`. Total job time 664 s against about 875 s; 431 s from the first job's start to the last job's end, against 567 s. (It waited 868 s for a slot behind other pipelines, so wall time from creation says nothing here.) ## Merge Danger **Door:** two-way Reverting the commit brings the job back. **Blast Radius:** coverage No browser suite checks a preview once it is deployed. `review` still runs `deploy/verify.sh` against it (health, origin check, noindex), and `e2e` covers the app.
project_1_bot_05dcee5cd59f879ab35191d664847a9d commented 2026-10-13 12:16:44 +00:00 (Migrated from gitlab.core-project.space)

mentioned in merge request !512

mentioned in merge request !512
project_1_bot_05dcee5cd59f879ab35191d664847a9d commented 2026-10-13 12:36:08 +00:00 (Migrated from gitlab.core-project.space)

changed the description

changed the description
project_1_bot_05dcee5cd59f879ab35191d664847a9d commented 2026-10-13 12:38:29 +00:00 (Migrated from gitlab.core-project.space)

added 3 commits

  • 3ad51245...b88b2982 - 2 commits from branch main
  • 8b0a53dc - ci: drop the browser suite against the preview, which e2e already runs

Compare with previous version

added 3 commits <ul><li>3ad51245...b88b2982 - 2 commits from branch <code>main</code></li><li>8b0a53dc - ci: drop the browser suite against the preview, which e2e already runs</li></ul> [Compare with previous version](/amaurycoudr/chess-project/-/merge_requests/10/diffs?diff_id=45&start_sha=3ad5124514223a5ed461583fab94553c63a812cb)
project_1_bot_05dcee5cd59f879ab35191d664847a9d commented 2026-10-13 12:48:03 +00:00 (Migrated from gitlab.core-project.space)

added 3 commits

  • 8b0a53dc...9bd3ffd6 - 2 commits from branch main
  • a84b494b - ci: drop the browser suite against the preview, which e2e already runs

Compare with previous version

added 3 commits <ul><li>8b0a53dc...9bd3ffd6 - 2 commits from branch <code>main</code></li><li>a84b494b - ci: drop the browser suite against the preview, which e2e already runs</li></ul> [Compare with previous version](/amaurycoudr/chess-project/-/merge_requests/10/diffs?diff_id=58&start_sha=8b0a53dc8254a86e98d3eed401c2391832b3ee89)
root (Migrated from gitlab.core-project.space) merged commit into main 2026-10-13 12:50:34 +00:00
Sign in to join this conversation.
No description provided.