feat: rated Puzzles with Themes, Hints, Replays and a History #554
No reviewers
Labels
No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
spec
wayfinder:grilling
wayfinder:map
wayfinder:prototype
wayfinder:research
wayfinder:task
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
amaurycoudr/chess-project!554
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "feat/puzzles-440"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
A signed-in Player trains on rated Puzzles (a curated Lichess sample), with a Glicko-2 Puzzle rating, Themes, Hints, unrated Replays and a History.
deploy/compose.yaml), outside the devtools gate.nextserves the first unseen Puzzle by id instead of a random one, so e2e knows what it gets (ADR 0039, one new line).puzzleslayer in the API order (ADR 0044, API standards);puzzles/in both apps' lint configs and standards rule 1; the whole-sample load test moved totest:slow(CONTRIBUTING.md,turbo.json).Owner decisions on review points:
historyfilters withresult?likegame.list; an unknown Theme is a plainBAD_REQUEST(closed enum); History pages with "Show more"; no credit line.Evidence
After: gate green on
e8d677c2(lint, typecheck, build, format:check, test: engine 26 files, API 38 files / 955 tests, front 75 files).puzzles.spec.tspasses on thedevandbuilttargets:pnpm turbo run test:slow --filter=@chess/api: the whole committed sample loads on a fresh database, none rejected (~55 s).rpc-games.integration.test.ts"a Game whose write fails" fails about 1 run in 6 withReceived unexpected parseComplete message from backend, also with main's games code.Merge Danger
Door: two-way
Three new tables (
puzzles,puzzle_ratings,puzzle_attempts), all additive; reverting isgit revertplus the usual migration rollback (ADR 0031). Ratings and Attempts are new data, nothing existing is rewritten.Blast Radius: deploys
puzzlesstep (about a minute of CPU to engine-check 53k lines; #448 makes it cheaper). A failing load fails the deploy.Closes #440
Closes #441
Closes #442
Closes #443
Closes #444
Closes #445
Closes #446
Closes #447
added 1 commit
f3dc8a8a- fix(repo): let the Puzzle sample into the image's build contextCompare with previous version
Screenshots
Before is production, after is this merge request's review app at
f3dc8a8.Desktop
Mobile